Github Push to hicknhack-software/Qt-Creator
-
Doc: Use lowercase dependency types
They are interpreted case-insensitively, but we use lowercase for our
own plugins' meta data.
Change-Id: Ic1da41f9fe21ed381c6be30be7238c196887dce5
Reviewed-by: Marcus Tillmanns
Reviewed-by: Leena Miettinen
-
ExtensionSystem: Fix that IsoIconBrowser indirectly enabled QmlDesigner
Normally, when a plugin is enabled, all its dependencies are indirectly
force-enabled too. This logic was added when we ran into the situation
that in a new version of Qt Creator an existing plugin A got a new
dependency on another existing plugin B, and if users previously
disabled plugin B, plugin A would silently not load, leading to broken
features without any hint on what was going on.
Now we do have a new situation: QmlDesigner's functionality is extended
by plugins, but QmlDesigner is disabled by default in Qt Creator. So
far, all the plugins that extend QmlDesigner were either also disabled
by default (and the whole set was explicitly enabled for the Qt Design
Studio installation), or they were not Qt Creator plugins, but managed
by a separate "QmlDesigner plugin manager". The latter has changed, and
the IsoIconBrowser plugin that extends QmlDesigner was changed to a
"regular" Qt Creator plugin.
This leads to the effect that if IsoIconBrowser is enabled by default,
it forces QmlDesigner to be enabled, which we do not want. But if
IsoIconBrowser is disabled by default, users who enable QmlDesigner also
need to enable IsoIconBrowser manually to get that functionality (and
users probably don't know about that).
Disable the "indirectly force-enable dependencies" mechanism for
dependencies that are disabled by default.
Fixes: QTCREATORBUG-32907
Change-Id: I97e279d9ac8a252fed260b3ffc7dd7ebc0135d7d
Reviewed-by: Marcus Tillmanns
Reviewed-by: Leena Miettinen
-
Qbs: Fix unarchiver test
Amends cc58397b2b65670a1d803a54b7665887f25a7a0f.
Change-Id: Icefbebd7694652d5e031083e503323fdc7e8dd2b
Reviewed-by: Christian Kandeler
-
qmljs formatter: take tab setting into account
Prior to this commit, built-in qml formatter was always inserting spaces
even if tabSettings is in use-tabs mode only when "Reformat Document" action
invoked. Auto format on save was working correct because it rewrites the
document on save() taking the tab settings into account.
To fix this, indent the blocks after formatting is performed.
Also, apply the current codestyle before formatting performed. This
makes sure the current tab settings are applied to document.
Task-number: QTCREATORBUG-32951
Task-number: QTCREATORBUG-32963
Change-Id: Ia862f607cafa40078a25beb4b06e67b7c7ca8b94
Reviewed-by: Sami Shalayel
-
qmlformat: do not override tabSettings
This was a redundant change and introduced a bug on auto-indent
behaviour.
a7e5b68bed194d603bd6adc767ac335146b5b7f7 introduced a seperate
tabSettings for qmljs documents which introduced incorrect behavior
(tabSettings being not responsive to the changes from preferences menu).
In fact having a separate tabSetting for qmljs document was not actually
needed. With this change, generatic tabSettings from
TextDocument is used.
Task-number: QTCREATORBUG-32951
Task-number: QTCREATORBUG-32963
Change-Id: Ie492ac38588e340a95b82e4e089905da93fc1eef
Reviewed-by: Sami Shalayel
-
qmlformat: fix preview
qmlformat uses default tab width is 4 while TabSetting class uses 8.
This caused preview to display deeper indent than the actual formatter
have.
Fixes: QTCREATORBUG-32951
Fixes: QTCREATORBUG-32963
Change-Id: Idafd86819ee5c48e8899d74b23a589a8ae799ddc
Reviewed-by: Sami Shalayel
-
Document qmlformat global configuration
Fixes: QTCREATORBUG-32964
Change-Id: Ie993398ba8e1d0db22a40e2b7edd11d10ce6c381
Reviewed-by: Leena Miettinen
Reviewed-by: Olivier De Cannière
Reviewed-by: Sami Shalayel
-
ClearCase: Skip two flaky tests
They regularly pass or fail on different
platforms and I have no idea how to fix.
Change-Id: Ibe8486f8c8ef620a772d3bcfdca138bcd73526b0
Reviewed-by: Orgad Shaneh
-
QmlJSEditor: Fix crash with null project
Change-Id: I419289ca6dec75b3bd59e079c1efdd6197c2a738
Reviewed-by: Sami Shalayel
-
CMakePM: Parse the CMakeLists.txt file to find out the project's name
The displayName of the project is used for the macro %{Project:Name}.
We used to get the project's parent directory as the project's name,
until the CMake project was parsed and the real project name was set.
This way we can have the proper name from the start.
QMake doesn't have this problem, since the project name is part of the
project filename e.g. .pro
Fixes: QTCREATORBUG-32996
Change-Id: I51b379b3db864f454260e39d6ad61bf2e52f9f51
Reviewed-by: Eike Ziller
-
Doc: Update screenshots of Welcome and Debug mode views
Add references to existing screenshots in more places.
Task-number: QTCREATORBUG-32575
Change-Id: Ic1425ab0c70c6045b79a38351bd319ea7eb39ec7
Reviewed-by: Eike Ziller
Reviewed-by: Teea Põldsam
Reviewed-by: hjk
-
Revert "ES: Fix that IsoIconBrowser indirectly enabled QmlDesigner"
This reverts commit f8cfa50081c6c7890682833e92b64b4c3ac62b79.
QmlDesigner is disabled by default, and IsoIconBrowser is enabled by
default, and the goal was to prevent IsoIconBrowser from loading if
QmlDesigner isn't explicitly enabled.
Unfortunately this conflicts with what we do with AiAssistant:
LuaLanguageClient is disabled by default, and AiAssistant is enabled by
default, and we want AiAssistant to load and indirectly enable
LuaLanguageClient.
We also cannot "manually" enable LuaLanguageClient when the user
installs AiAssistant, because that would not fix any existing
installations.
Task-number: QTCREATORBUG-32907
Fixes: QTCREATORBUG-33010
Change-Id: I0bc95ee8c75804c45cae9e84a3c78d54a5c9e984
Reviewed-by: Marcus Tillmanns
-
Wizards: Update translation text
Amends 65b8b42cf6247a048763874dcce45b1ceb8d7ec2
Task-number: QTCREATORBUG-32896
Change-Id: Ib4431bb13bff8c66709bdade893cbccc9f868422
Reviewed-by: Eike Ziller
Reviewed-by: Leena Miettinen
-
Doc: Be more descriptive wrt environment/path settings in the FAQ
Expand on the reasons, the affected systems, and link to the solution
(the environment settings).
Task-number: QTCREATORBUG-33016
Change-Id: Iaa251a22f7be8818e983f3e2be0d0eeed5981d57
Reviewed-by: Leena Miettinen
Reviewed-by: Christian Kandeler
-
ExtensionSystem: Allow plugins to "recommend" other plugins
The isoiconbrowser plugin extends the qmldesigner plugin, but since
qmldesigner is disabled by default, both of them need to be disabled by
default.
Normally, when enabling qmldesigner, the isoiconbrowser would stay
disabled, since qmldesigner doesn't even know about this plugin. This is
ugly, because users will not know that there are plugins that extend the
functionality of qmldesigner that they could enable.
Add a list of "recommended" plugins to the plugin meta data. These are
currently automatically enabled when enabling the plugin, so that
enabling qmldesigner also enables isoiconbrowser, as if it were a
dependency of qmldesigner.
In the future it would be nice if the "recommended" plugins were also
only "recommended" in the UI when enabling the plugin, but that requires
UI changes that cannot be done in Qt Creator 17 anymore.
Fixes: QTCREATORBUG-32907
Change-Id: I128555601116c487de073cbb3353496dbc8b48be
Reviewed-by: Leena Miettinen
Reviewed-by: Marcus Tillmanns
-
SquishTests: Adapt to new restriction inside wizard
Change-Id: I61cefad41bd9700b51f411b2070396974eeb4396
Reviewed-by: Jukka Nokso
Reviewed-by: Christian Stenger
-
LanguageClient: rename Client::activeClient -> activatable
Amends 64d2144fb5147fc99890ce7e3a6aa466ce290999
Change-Id: I7348f1fd2a1092739fa11ff9bad34fbbbb3917a9
Reviewed-by: Marcus Tillmanns
-
LanguageClient: make deactivateEditor a standalone function
Task-number: QTCREATORBUG-32945
Change-Id: I08909a2af7af9eaac7a1563e2e3c107f0cf76870
Reviewed-by: Christian Stenger
-
ScxmlEditor: Fix leaks on exit
This gives to orphan widgets a parent. Kudos to AddressSanitizer.
Change-Id: Ie819870e79aea5e8f332d0e656ccc3872a929da7
Reviewed-by: Christian Stenger
-
Core: Don't show empty PopupInfoBarDisplay
This sets the visibility of the PopupInfoBarDisplay instance if it does
not contain entries. Otherwise, the PopupInfoBarDisplay is shown as 1px
high line.
Fixes: QTCREATORBUG-33017
Change-Id: I50de3b314902a4e601bad523a386eda2e1006791
Reviewed-by: Eike Ziller